eson/googletest
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Stop TestInfo::Run() calling a function through null pointer

Browse Source 
If the object was never created then trying to call &Test::DeleteSelf_
will dereference a null pointer, with undefined behaviour.

Fixes #845
This commit is contained in:
Jonathan Wakely 2016-12-23 01:56:14 +00:00 committed by Knut Omang
parent 9a502a5b14
commit 48e6f1f387
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
googletest/src/gtest.cc
View File

@ -2675,10 +2675,12 @@ void TestInfo::Run() {
test->Run();
}
if (test != NULL) {
// Deletes the test object.
impl->os_stack_trace_getter()->UponLeavingGTest();
internal::HandleExceptionsInMethodIfSupported(
test, &Test::DeleteSelf_, "the test fixture's destructor");
test, &Test::DeleteSelf_, "the test fixture's destructor");
}
result_.set_elapsed_time(internal::GetTimeInMillis() - start);