eson/googletest
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add additional valid characters to parameter names

Browse Source 
I feel as though the alphanumeric + `_` charset is too restrictive, especially when formatting complex objects into names.  Added a few extra characters which will help with this.
This commit is contained in:
Derek Brown 2020-01-14 18:23:30 -08:00 committed by GitHub
parent d854bd6acc
commit 4483e8137a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
googletest/include/gtest/internal/gtest-param-util.h
View File

@ -633,6 +633,8 @@ class ParameterizedTestSuiteInfo : public ParameterizedTestSuiteInfoBase {
int line; int line;
}; };
typedef ::std::vector<InstantiationInfo> InstantiationContainer; typedef ::std::vector<InstantiationInfo> InstantiationContainer;
static std::string validParamChars = "_-:/";
static bool IsValidParamName(const std::string& name) { static bool IsValidParamName(const std::string& name) {
// Check for empty string // Check for empty string
@ -641,7 +643,7 @@ class ParameterizedTestSuiteInfo : public ParameterizedTestSuiteInfoBase {
// Check for invalid characters // Check for invalid characters
for (std::string::size_type index = 0; index < name.size(); ++index) { for (std::string::size_type index = 0; index < name.size(); ++index) {
if (!isalnum(name[index]) && name[index] != '_') if (!isalnum(name[index]) && validParamChars.find(name[index]) == std::string::npos)
return false; return false;
} }