From 213a8a8f3969b08d3336891ea6bf84e8f954c2e3 Mon Sep 17 00:00:00 2001 From: Arthur O'Dwyer Date: Sat, 28 Mar 2020 14:36:36 -0400 Subject: [PATCH] Fix -Wdeprecated warning in this test code. NFC. /home/travis/build/Quuxplusone/googletest/googletest/test/googletest-port-test.cc:97:11: error: definition of implicit copy constructor for 'Base' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated] virtual ~Base() {} ^ /home/travis/build/Quuxplusone/googletest/googletest/test/googletest-port-test.cc:116:56: note: implicit copy constructor for 'Base' first required here Base base = ::testing::internal::ImplicitCast_(derived); ^ --- googletest/test/googletest-port-test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/googletest/test/googletest-port-test.cc b/googletest/test/googletest-port-test.cc index 60d637c3..da3a5a53 100644 --- a/googletest/test/googletest-port-test.cc +++ b/googletest/test/googletest-port-test.cc @@ -90,9 +90,9 @@ TEST(IsXDigitTest, ReturnsFalseForWideNonAscii) { class Base { public: - // Copy constructor and assignment operator do exactly what we need, so we - // use them. Base() : member_(0) {} + Base(const Base&) = default; + Base& operator=(const Base&) = default; explicit Base(int n) : member_(n) {} virtual ~Base() {} int member() { return member_; }