Merge branch 'release/0.6.3'

tree/heap/heap.go

@@ -110,7 +110,6 @@ func (h *Heap) Pop() (interface{}, bool) {
 
 	downvalue := h.elements[h.size]
 	var cidx, c1, c2 int
-	var cvalue1, cvalue2 interface{}
 	// down
 	for {
 		cidx = curidx << 1
@@ -119,23 +118,16 @@ func (h *Heap) Pop() (interface{}, bool) {
 		c2 = cidx + 2
 
 		if c2 < h.size {
-
+			if h.Compare(h.elements[c1], h.elements[c2]) >= 0 {
-			cvalue2 = h.elements[c2]
-			cvalue1 = h.elements[c1]
-
-			if h.Compare(cvalue1, cvalue2) >= 0 {
 				cidx = c1
 			} else {
 				cidx = c2
 			}
 		} else {
 			cidx = c1
-			if c1 < h.size {
+			if c1 >= h.size {
-				cvalue1 = h.elements[c1]
-			} else {
 				break
 			}
-
 		}
 
 		if h.Compare(h.elements[cidx], downvalue) > 0 {

tree/heap/heap_test.go

@@ -9,6 +9,9 @@ import (
 )
 
 func TestHeapGrowSlimming(t *testing.T) {
+
+	for ii := 0; ii < 1000; ii++ {
+
 		h := New(compare.Int)
 		var results []int
 		for i := 0; i < 100; i++ {
@@ -52,6 +55,7 @@ func TestHeapGrowSlimming(t *testing.T) {
 		if !h.Empty() {
 			t.Error("clear reborn is error")
 		}
+	}
 
 }
 
@@ -80,8 +84,44 @@ func TestHeapPushTopPop(t *testing.T) {
 	if h.Size() != 0 {
 		t.Error("heap size is not equals to zero")
 	}
+
+	h.Clear()
+
+	l = []int{3, 5, 2, 7, 1}
+
+	for _, v := range l {
+		h.Put(v)
+	}
+
+	sort.Slice(l, func(i, j int) bool {
+		if l[i] > l[j] {
+			return true
+		}
+		return false
+	})
+
+	for i := 0; !h.Empty(); i++ {
+		v, _ := h.Pop()
+		if l[i] != v {
+			t.Error("heap is error")
+		}
+	}
 }
 
+// func BenchmarkPush(b *testing.B) {
+// 	h := New(compare.Int)
+// 	b.N = 40000000
+// 	var results []int
+// 	for i := 0; i < b.N; i++ {
+// 		results = append(results, randomdata.Number(0, 1000000000))
+// 	}
+
+// 	b.ResetTimer()
+// 	for _, v := range results {
+// 		h.Put(v)
+// 	}
+// }
+
 // func Int(k1, k2 interface{}) int {
 // 	c1 := k1.(int)
 // 	c2 := k2.(int)